chore: bump to istanbul alphas #9192
Conversation
SimenB
force-pushed
the
istanbul
branch
2 times, most recently
from
5113b17 to
13241d4
Compare
Only if you've already dropped node.js 6 (these new versions require node.js 8). |
|
Yeah, we've landed that on master, just not released yet. I see we have a windows test failure, though...
|
Codecov Report
@@ Coverage Diff @@
## master #9192 +/- ##
==========================================
+ Coverage 65.07% 65.08% +0.01%
==========================================
Files 281 278 -3
Lines 11864 11861 -3
Branches 2920 2922 +2
==========================================
Hits 7720 7720
+ Misses 3515 3512 -3
Partials 629 629Continue to review full report at Codecov.
|
|
added some |
| @@ -6990,7 +6990,7 @@ [email protected]: | |||
| duplexer "^0.1.1" | |||
| pify "^4.0.1" | |||
|
|
|||
| handlebars@^4.4.0, handlebars@^4.4.2: | |||
| handlebars@^4.4.0: | |||
There was a problem hiding this comment.
for anyone curious - this comes from https://www.npmjs.com/package/conventional-changelog-writer which comes via lerna, a dev tool. this change means people installing Jest will no longer get handlebars (or uglify)
|
Let's land this so it can be included in the upcoming beta release of jest |
* master: chore: upgrade to fsevents 2 (jestjs#9215) docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149) chore: bump to istanbul alphas (jestjs#9192) Fix typo in JestPlatform.md (jestjs#9212) jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203) fix(jest-types): tighten Config types and set more defaults (jestjs#9200) jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132) jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198) chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197) fix(pretty-format): correctly detect memo (jestjs#9196) chore: regenerate lockfiles in e2e tests (jestjs#9193) chore: bump handlebars
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
/cc @coreyfarrell. I've updated some snapshots that looked correct, but left a few alone.
I'll update after you've fixed thesourceFinderissueTest plan
Green CI. We'll need to figure out what to do about TS types. Should probably wait for this to be stable as well. We can upgrade without a new major anyways as this is all internal stuff. I wouldn't consider changes in the coverage report to be breaking