Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 MacCatalyst: DoubleConversion.h not found #1680

Closed
ZComwiz opened this issue Nov 28, 2021 · 1 comment
Closed

🐛 MacCatalyst: DoubleConversion.h not found #1680

ZComwiz opened this issue Nov 28, 2021 · 1 comment

Comments

@ZComwiz
Copy link

ZComwiz commented Nov 28, 2021

Problem
When building React Native on versions AFTER 64.0 to MacCatalyst target, Flipper-Folly cannot find <double-conversion/double-conversion.h> in Conv.h

Likely this is because Folly switched to using an xcFramework pattern but did not properly include MacCatalyst slices (speculating).

There is some scripting info here on how to possibly go about that and also here on this blog post.

If either @simpkins or @Orvid can weigh in on this, that would be awesome 🤩

@yfeldblum
Copy link
Contributor

I don't think this issue really applies to folly. This might be better raised in the react-native repo.

@yfeldblum yfeldblum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants