Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow does not understand tagged template string parameters #4732

Closed
vicapow opened this issue Aug 28, 2017 · 5 comments
Closed

Flow does not understand tagged template string parameters #4732

vicapow opened this issue Aug 28, 2017 · 5 comments

Comments

@vicapow
Copy link
Contributor

vicapow commented Aug 28, 2017

/* @flow */

const myTag = (strings: Array<string>, ...expressions: Array<number>) => '';
myTag`${"foo"}`; // Expected error 'number expected but found string' but no error reported.

flow.org/try

@vicapow
Copy link
Contributor Author

vicapow commented Aug 28, 2017

This is blocking: flow-typed/flow-typed#1183

@asolove
Copy link
Contributor

asolove commented Aug 28, 2017

Just adding some links to related issues: #3936, #2616, appears in a todo list in #560.

@vkurchatkin
Copy link
Contributor

#3936 should be super-easy

@leebyron
Copy link
Contributor

Fixed in f8875fd

@vicapow
Copy link
Contributor Author

vicapow commented Jan 25, 2019

woo! sweet.

@vicapow vicapow closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants