-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getdeps: fix xxhash build on windows #624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/zstrong#1015 fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake X-link: facebook/fbthrift#624 Reviewed By: andreacampi Differential Revision: D64592635 Pulled By: ahornby fbshipit-source-id: 5dc558e8786fa1264ba0e89026ca750d1a285dea
Summary: fbthrift needs xxhash but xxhash manifest had no builder defined on windows Add xxhash windows build support using cmake Test Plan: build xxhash locally on windows with: `python ./build/fbcode_builder/getdeps.py build xxhash` Before [broken, no builder](https://github.com/ahornby/fbthrift/actions/runs/11401030867/job/31723096967#step:31:23) ``` Mapping scratch dir C:\Users\RUNNER~1\AppData\Local\Temp\fbcode_builder_getdeps-DZZaZfbthriftZfbthriftZbuildZfbcode_builder -> Z:\ Building on {distro=None, distro_vers=10, fb=off, fbsource=off, os=windows, shared_libs=off, test=off} Assessing xxhash... Traceback (most recent call last): File "build/fbcode_builder/getdeps.py", line 1452, in <module> sys.exit(main()) File "build/fbcode_builder/getdeps.py", line 1435, in main return args.func(args) File "build/fbcode_builder/getdeps.py", line 108, in run self.run_project_cmd(args, loader, manifest) File "build/fbcode_builder/getdeps.py", line 653, in run_project_cmd dep_manifests, File "D:\a\fbthrift\fbthrift\build\fbcode_builder\getdeps\manifest.py", line 685, in create_prepare_builders builder = self.get_builder_name(ctx) File "D:\a\fbthrift\fbthrift\build\fbcode_builder\getdeps\manifest.py", line 481, in get_builder_name raise Exception("project %s has no builder for %r" % (self.name, ctx)) Exception: project xxhash has no builder for <getdeps.manifest.ManifestContext object at 0x0000021606FDE388> ``` After, works: ``` $ python ./build/fbcode_builder/getdeps.py build xxhash Mapping scratch dir C:\Users\alex\AppData\Local\Temp\fbcode_builder_getdeps-CZZUsersZalexZlocalZfbthriftZbuildZfbcode_builder -> Z:\ Building on {distro=None, distro_vers=10, fb=off, fbsource=off, os=windows, shared_libs=off, test=on} Assessing ninja... Assessing cmake... Assessing xxhash... alex@fridge MINGW64 ~/local/fbthrift $ echo $? 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getdeps: fix xxhash build on windows
Summary:
fbthrift needs xxhash but xxhash manifest had no builder defined on windows
Add xxhash windows build support using cmake
Test Plan:
build xxhash locally on windows with:
python ./build/fbcode_builder/getdeps.py build xxhash
Before broken, no builder
After, works: