New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shallowEqual() should handle NaN values correctly #101

Closed

rickbeerendonk opened this issue Jan 9, 2016 · 1 comment

rickbeerendonk commented Jan 9, 2016

shallowEqual() should return true when dealing with NaN.

shallowEqual(NaN, NaN);  // true
shallowEqual({a: NaN}, {a: NaN});  // true

Fixing this would also fix the confusing error in React, see React Issue 5773.

The text was updated successfully, but these errors were encountered:

rickbeerendonk mentioned this issue

shallowEqual returns true when dealing with NaN #102

Closed

Member

zpao commented Jan 11, 2016

As mentioned, will be syncing this out from internal at some point, but yes, we will be doing this.

zpao closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment