Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CRA version in react-scripts eject warning. #6845

Merged
merged 2 commits into from Apr 19, 2019
Merged

Change CRA version in react-scripts eject warning. #6845

merged 2 commits into from Apr 19, 2019

Conversation

lffg
Copy link
Contributor

@lffg lffg commented Apr 18, 2019

Fixes #6838.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Contributor

iansu commented Apr 18, 2019

I think we probably want to say something like Create React App 2+ or Create React App 2 and above.

@iansu iansu self-assigned this Apr 18, 2019
@iansu iansu added this to the 3.0 milestone Apr 18, 2019
@lffg
Copy link
Contributor Author

lffg commented Apr 18, 2019

Fixed, @iansu.

@iansu iansu merged commit 022b984 into facebook:master Apr 19, 2019
@iansu
Copy link
Contributor

iansu commented Apr 19, 2019

Thanks!

@lffg lffg deleted the patch-1 branch April 19, 2019 03:48
@lock lock bot locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees

@iansu iansu

Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

CRA@3: Eject warning message references CRA2
3 participants
@lffg @facebook-github-bot @iansu