From 26b2993f8fd1d79a26677b5e88757762f299d180 Mon Sep 17 00:00:00 2001 From: Jack Wilsdon Date: Thu, 21 Mar 2019 14:33:05 +0000 Subject: [PATCH 1/2] Remove project property from @typescript-eslint/parser options The "project" property has a significant performance impact on linting, and none our rules currently need it. Fixes #6661. --- packages/eslint-config-react-app/index.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 441b501843c..781c52dd837 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -30,8 +30,6 @@ const fs = require('fs'); // https://github.com/facebook/create-react-app/issues/637 const appDirectory = fs.realpathSync(process.cwd()); const resolveApp = relativePath => path.resolve(appDirectory, relativePath); -const projectRootPath = resolveApp('.'); -const tsConfigPath = resolveApp('tsconfig.json'); module.exports = { root: true, @@ -73,8 +71,6 @@ module.exports = { }, // typescript-eslint specific options - project: tsConfigPath, - tsconfigRootDir: projectRootPath, warnOnUnsupportedTypeScriptVersion: true, }, plugins: ['@typescript-eslint'], From 48a13e477c1ef233af70f8913ddb443de202a695 Mon Sep 17 00:00:00 2001 From: Ian Schmitz Date: Sun, 24 Mar 2019 13:28:48 -0700 Subject: [PATCH 2/2] Remove unnecessary code --- packages/eslint-config-react-app/index.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 781c52dd837..4026a82f427 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -23,14 +23,6 @@ // To use them, explicitly reference them, e.g. `window.name` or `window.status`. const restrictedGlobals = require('confusing-browser-globals'); -// The following is copied from `react-scripts/config/paths.js`. -const path = require('path'); -const fs = require('fs'); -// Make sure any symlinks in the project folder are resolved: -// https://github.com/facebook/create-react-app/issues/637 -const appDirectory = fs.realpathSync(process.cwd()); -const resolveApp = relativePath => path.resolve(appDirectory, relativePath); - module.exports = { root: true,