Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you fix index.html after building #6337

Closed
Automedon opened this issue Feb 3, 2019 · 1 comment
Closed

Can you fix index.html after building #6337

Automedon opened this issue Feb 3, 2019 · 1 comment
Assignees

Comments

@Automedon
Copy link

After building in paths we get like href="/favicon.ico" or href="/static/css/main.894a7f1d.chunk.css" and for proper working and for deplyoing it need to be changed in href="./favicon.ico" and href="./static/css/main.894a7f1d.chunk.css". And also i found that many people get the error( Failed to load resource: the server responded with a status of 404 ()) after deploying their apps, for example, on github pages, and get white blank. Because path are wrong.

@mrmckeb mrmckeb self-assigned this Feb 3, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Feb 3, 2019

Hi @Automedon, this looks similar to #1910.

One way to solve this is to keep the existing files available for some time after deployment of a new version, but also look into ways to invalidate the existing HTML file - perhaps there's an aggressive CDN in the way?

You could also look at tweaking your service worker. There are a few discussions on this topic available, such as GoogleChromeLabs/sw-precache#356.

Let me know if you have any other questions!

@mrmckeb mrmckeb closed this as completed Feb 3, 2019
@lock lock bot locked and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants