Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] and react-styleguidist@7 incompatibility #4567

Closed
SavePointSam opened this issue Jun 5, 2018 · 5 comments
Closed

[email protected] and react-styleguidist@7 incompatibility #4567

SavePointSam opened this issue Jun 5, 2018 · 5 comments

Comments

@SavePointSam
Copy link

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

N/A

Environment

Environment:
OS: macOS High Sierra 10.13.4
Node: 8.11.1
Yarn: 1.7.0
npm: 6.1.0
Watchman: Not Found
Xcode: Not Found
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-dom: 16.2.0 => 16.2.0
react-scripts: 2.0.0-next.66cc7a90 => 2.0.0-next.66cc7a90

Steps to Reproduce

  1. create app with [email protected]
  2. Add react-styleguidist@7
  3. start application development server with yarn start or npm run start

Expected Behavior

The application server should start without failing a pre-flight check

Actual Behavior

Application server fails to start due to strict matching on webpack-dev-server to version 2.11.0 and react-styleguidist@7 uses [email protected]

Reproducible Demo

I don't have time to build one right now. I'll add one if I have time later.

@SavePointSam
Copy link
Author

While not a long term solution, nor a suggested, nor supported solution; I was able to temporarily solve this issue by locking webpack-dev-server in my package.json

{
  ...
  "devDependencies": {
    ...
    "webpack-dev-server": "2.11.0"
  }
}

@bugzpodder
Copy link

fyi there is another issue with running styleguidist on @next: #4477

@Timer
Copy link
Contributor

Timer commented Jul 23, 2018

These two things should never be installed side-by-side, so I'm closing this. There's too many nuanced bugs in package managers and packages for us to even attempt to solve this; the package manager should handle it.

@Timer Timer closed this as completed Jul 23, 2018
@SavePointSam
Copy link
Author

@Timer CRA currently supports using react-styleguidist. Is react-scripts 2 removing support for this then?

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#getting-started-with-styleguidist

@Timer
Copy link
Contributor

Timer commented Jul 23, 2018

react-scripts 2 will change how this works, suggesting you install it to a monorepo/separate package.
Plus, we don't have "support" for it -- this was a contributor-provided guide that we don't know how to support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants