Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapillary Image type filtering is not working #955

Closed
Bonkles opened this issue Jun 8, 2023 · 3 comments
Closed

Mapillary Image type filtering is not working #955

Bonkles opened this issue Jun 8, 2023 · 3 comments
Assignees
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Jun 8, 2023

Description

This one came to us by way of Mapillary, from Said Turksever.

Actual behaviour:

  • Enable Mapillary imagery layer
  • Mapillary imagery layer will be available both flat and panoramic imagery
  • Enable only flat or panoramic imagery
  • Mapillary Imagery will not be filtered on the map view

Expected behaviour

  • Enable Mapillary imagery layer
  • Mapillary imagery layer will be available both flat and panoramic imagery
  • Enable only flat or panoramic imagery
  • Mapillary Imagery needs to be filtered based on enabled selection based on imagery type

Version

2.0.1

What browser are you seeing the problem on? What version are you running?

All

The OS you're using

MacOS

Steps to reproduce

See description!

The browser URL at the time you encountered the bug

n/a

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

@Bonkles Bonkles self-assigned this Jun 8, 2023
@Bonkles Bonkles added this to the v2.1 milestone Aug 24, 2023
@tordans
Copy link

tordans commented Aug 31, 2023

@Bonkles I think this should be reopened.

In v2.1 I see that the filter does filter the image circles, but it does not hide the image-lines.

Example: https://rapideditor.org/edit#background=Berlin-2022&data=https://atlas-tiles.s3.eu-central-1.amazonaws.com/berlin-parking-polygons-euvm.pmtiles&datasets=fbRoads,msBuildings&disable_features=boundaries&map=19.21/52.49931/13.34098&photo=mapillary/1003782916887121&photo_overlay=mapillary

FYI, the date filter hides both, the line and the circle.

image

@Bonkles Bonkles reopened this Aug 31, 2023
@Bonkles
Copy link
Contributor Author

Bonkles commented Aug 31, 2023

Fixed the filtering so that the tracks are also hidden on click for pano/flat.

mapillary_tracks_hide.mov

@Bonkles
Copy link
Contributor Author

Bonkles commented Aug 31, 2023

This should be fixed in 2.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants