Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preset picker is not brought up when a new line or area is drawn #608

Closed
Bonkles opened this issue Oct 4, 2022 · 1 comment
Closed

Preset picker is not brought up when a new line or area is drawn #608

Bonkles opened this issue Oct 4, 2022 · 1 comment
Assignees
@Bonkles
Milestone
v2 Alpha 3

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Oct 4, 2022 •
edited
Loading

Just after you create a new area or way, the 'preset picker' should appear in the left-hand sidebar to prompt you to pick a type for the shape:

Image

We should be doing the same in v2.
@Bonkles Bonkles moved this to 🏗 In progress in RapiD v2 Release Board Oct 4, 2022
@Bonkles Bonkles self-assigned this Oct 4, 2022
@Bonkles Bonkles added this to the v2 Beta milestone Oct 4, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Oct 4, 2022

Fixed in 8b27ce1cce0e59608407c17fe63d7b93047a1ce1. The finish() method of both line draw and area drawing modes just needed to have their 'select mode' entrance calls ornamented with a .newFeature(true) call.

@Bonkles Bonkles closed this as completed Oct 4, 2022
@Bonkles Bonkles mentioned this issue Oct 4, 2022
Closed
@Bonkles Bonkles moved this from 🏗 In progress to 🔖 Pending Release in RapiD v2 Release Board Oct 4, 2022
@Bonkles Bonkles moved this to Pending Release in Rapid v2 Beta Board Nov 30, 2022
@Bonkles Bonkles moved this from Pending Release to Ready for QA ✅ in Rapid v2 Beta Board Dec 6, 2022
@Bonkles Bonkles moved this from Ready for QA ✅ to 🏁 Done in Rapid v2 Beta Board Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
None yet
Projects
Rapid v2 Beta Board
Status: 🏁 Done
Milestone
v2 Alpha 3
Development

No branches or pull requests
1 participant
@Bonkles