Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to custom map data feature #545

Open
2 of 6 tasks
tordans opened this issue Aug 11, 2022 · 3 comments
Open
2 of 6 tasks

Improvements to custom map data feature #545

tordans opened this issue Aug 11, 2022 · 3 comments
Labels
feature-streetview Issue or request related to the streetview viewer mapillary

Comments

@tordans
Copy link

tordans commented Aug 11, 2022

Description

(Let me know if you want this ticket in the iD repo rather than here. It looks like a "upstream" feature, but since custom data is kind of RapId's thing I thought it was better placed here.)

I tested the custom map data feature today and it has great potential for some QA projects we have in Berlin. (And IMO also for MapRoulette integration.)

Here are a few thinks I noticed, that could be improved…

  • Hash-URL: It looks like a custom URL is not reflected in the hash URL, so I don't have a way to link to a pre-configured setup. Example https://mapwith.ai/rapid#background=custom:https://tiles.codefor.de/berlin-2022-dop20rgbi/{zoom}/{x}/{y}.png&datasets=custom:https://parkraum.osm-verkehrswende.org/project-quality-assurance/berlin-parklets/gqis-for-maproulette.geojson&disable_features=boundaries&map=18.33/52.50039/13.40694&photo=&photo_dates=2021-01-01_&photo_overlay=mapillary
  • The "zoom on data" button does not do anything (?) (not in iD, not in Rapid)
  • Ideally, there would be "zoom in on selected data item" – like the feature Qunicy build vor the v3-Prototype (didn't he?)

The reuse of the "all tags" UI with the two column inputs and textarea is a bit rough.

  • One can click the "add +" button (which is reset when used, but still feels a bit broken to have)
  • It would be great if multiline input (values) where visible as text area or multi line text; in my specific setup I have a JSON which I feed into Maproulette with a "task" key and a value that is interpreted as Markdown by Maproulette. It would be great to view this with linebreaks in iD as well.
  • What could a workflow to copy and use a list of recommended tags look like? For example, I verified a feature on the map and want to copy recommended tags from the external data to use on my area or node.

image

Version

1.1.9

What browser are you seeing the problem on? What version are you running?

No response

Steps to reproduce

No response

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid#background=custom:https://tiles.codefor.de/berlin-2022-dop20rgbi/{zoom}/{x}/{y}.png&datasets=https://parkraum.osm-verkehrswende.org/project-quality-assurance/berlin-parklets/gqis-for-maproulette.geojson&disable_features=boundaries&map=20.00/52.50050/13.40575&photo=&photo_dates=2021-01-01_&photo_overlay=mapillary


Ping #585 because it's the same topic.

@Bonkles
Copy link
Contributor

Bonkles commented Aug 11, 2022

Thanks for submitting this @tordans! In the run-up to v2, we've started breaking tasks into individual, manageable chunks. I may 'check' one of these boxes and edit the line item to point to a separate bug.

@Bonkles
Copy link
Contributor

Bonkles commented Aug 14, 2023

Referencing #1016 as being directly related to this issue.

@tordans
Copy link
Author

tordans commented Aug 31, 2023

@Bonkles FYI I updated the check list above since a few things are fixed in 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-streetview Issue or request related to the streetview viewer mapillary
Projects
None yet
Development

No branches or pull requests

2 participants