Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderingContext error on mobile devices / WebGL v1 #493

Closed
Bonkles opened this issue Jul 7, 2022 · 5 comments
Closed

WebGLRenderingContext error on mobile devices / WebGL v1 #493

Bonkles opened this issue Jul 7, 2022 · 5 comments
Assignees
@Bonkles
Labels
bug Something isn't working feature-renderer Issue or request related to the renderer / WebGL
Milestone
v2 General Beta (...

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Jul 7, 2022

When starting safari desktop in webGL v1 mode, or when using chrome on mobile, I receive the following error:

PixiLayerOsm.js:150 Uncaught TypeError: Failed to execute 'texSubImage2D' on 'WebGLRenderingContext': parameter 9 is not of type 'ArrayBufferView'.
    at AtlasResource.uploadItem (PixiLayerOsm.js:150:1)
    at AtlasResource.upload (PixiLayerOsm.js:112:1)
    at TextureSystem2.updateTexture (BufferSystem.ts:314:50)
    at TextureSystem2.bind (BufferSystem.ts:161:22)
    at AbstractBatchRenderer2.bindAndClearTexArray (BatchPluginFactory.ts:456:27)
    at AbstractBatchRenderer2.drawBatches (BatchPluginFactory.ts:512:22)
    at AbstractBatchRenderer2.flush (BatchPluginFactory.ts:537:14)
    at AbstractBatchRenderer2.stop (BatchPluginFactory.ts:564:14)
    at BatchSystem2.setObjectRenderer (FramebufferSystem.ts:42:30)
    at BatchSystem2.flush (FramebufferSystem.ts:54:14)
@Bonkles Bonkles self-assigned this Jul 7, 2022
@Bonkles Bonkles added bug Something isn't working feature-renderer Issue or request related to the renderer / WebGL rapid v2 labels Jul 7, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Jul 7, 2022

looks like perhaps my source map is betraying me here- there are no such AtlasResource calls on the PixiLayerOsm.js lines mentioned.

@Bonkles
Copy link
Contributor Author

Bonkles commented Jul 19, 2022

Confirmed that there is a short-term bug with source maps in Chrome 103 (the current version) and have also confirmed that the bug has been found and fixed in chrome 104/105.

@Bonkles
Copy link
Contributor Author

Bonkles commented Jul 19, 2022

Will defer this one till later and simply hardcode the GL environment to use webGLv2 everywhere- it will soon be the default in pixi anyway. In our current version, webGL v2 is selected for desktop browsers and webGL v1 is used for mobile, hence the breakages.

@Bonkles Bonkles added this to the v2 General Availability milestone Aug 9, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Oct 26, 2022

Closing this one- we made the switch to webGL v2 preference for all platforms, seems to be working well.

@Bonkles Bonkles closed this as completed Oct 26, 2022
@Bonkles Bonkles moved this from Triage to 🔖 Pending Release in RapiD v2 Release Board Oct 26, 2022
@Bonkles Bonkles moved this to Pending Release in Rapid v2 Beta Board Nov 30, 2022
@Bonkles Bonkles moved this from Pending Release to Ready for QA ✅ in Rapid v2 Beta Board Dec 6, 2022
@Bonkles Bonkles moved this from Ready for QA ✅ to 🏁 Done in Rapid v2 Beta Board Dec 13, 2022
@bhousel bhousel mentioned this issue Apr 6, 2023
Closed
@ShukantPal
Copy link

Wow, I didn't know Facebook was using my library ❤️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
bug Something isn't working feature-renderer Issue or request related to the renderer / WebGL
Projects
Rapid v2 Beta Board
Status: 🏁 Done
Milestone
v2 General Beta (Extended)
Development

No branches or pull requests
2 participants
@Bonkles @ShukantPal