Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying properties of curbs strips connected crosswalk of most of its tags. #1268

Closed
mxxcon opened this issue Dec 22, 2023 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@mxxcon
Copy link

mxxcon commented Dec 22, 2023

Description

Curb node 11418980879 is connected to crosswalk way 1231253214 which has tags:

crossing=traffic_signals
footway=crossing
highway=footway

and it looks like this
image
If I modify any property of that curb, the mentioned crosswalk suddenly loses crossing=traffic_signals tag

footway=crossing
highway=footway

And it looks like
image

This problems exist on 2.2 and this canary build too.

Screenshots

No response

Version

2.2.0

What browser are you seeing the problem on? What version are you running?

Chrome v121.0

The OS you're using

win

Steps to reproduce

  1. modify any tag of a curb
  2. connected crosswalk loses tags

The browser URL at the time you encountered the bug

https://rapideditor.org/canary#background=EsriWorldImagery&datasets=fbRoads,msBuildings&disable_features=boundaries&id=n11418980879&map=20.92/40.59189/-73.93729

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36

@bhousel bhousel added the bug Something isn't working label Dec 22, 2023
@bhousel
Copy link
Contributor

bhousel commented Dec 22, 2023

Thanks for the report @mxxcon - It looks like the crossing-tag-sync code was running in some situations when it shouldn't.

If the user removes the crossing tags from the junction node, yes we want to sync that removal to the parent way - but if the user is just touching the kerb which has no crossing tags, we shouldn't try push "no crossing tags" up to the way.

I fixed things so that it will only try a sync if a crossing tag was actually involved in what the user did.

I just published a v2.2.1 patch release on rapideditor.org that includes this fix.

@bhousel bhousel added this to the 2.2.1 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants