Include keyboard key word alongside shortcut #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerwuster
force-pushed
the
keyboard_shortcut_details
branch
from
f5c973d to
f439304
Compare
bhousel
approved these changes
Dec 22, 2023
bhousel
added a commit
that referenced
this pull request
Jan 2, 2024
(re: #1272, re: #1261, re: #1255) Windows/linux should not replace '⌘Z' with 'Ctrl+Z', it should just replace it with '^Z' and then the `uiCmd.display` should handle how to present that to the user. This change simplifies the `uiCmd` code, and avoids the 'Ctrl+` stuff. It also changes `uiTooltip` to work with an array of keys, using d3-selection.each and `uiCmd.display` to render each one. Previous code was attempting to split the keycombo into chars, causing #1272 I still need to make sure that `tooltip.keys()` is being called consistently, with an Array of keys - we do this sometimes but not everywhere. Also, in 01a16a9, the '+' to zoom in broke, because it is a shifted key. This commit fixes that issue also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include the key word in all cases, because nobody knows what symbols mean. Closes #1255
