Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for service catalog feature #973

Closed
hrishin opened this issue Jan 3, 2018 · 5 comments · Fixed by #1605
Closed

Add support for service catalog feature #973

hrishin opened this issue Jan 3, 2018 · 5 comments · Fixed by #1605
Assignees
@kunal-kushwaha
Labels
feature gsoc candidate for GSoC

Comments

@hrishin
Copy link
Member

hrishin commented Jan 3, 2018

Need add DSL API's for Service Catalog resources

  • Broker
  • ServiceClass
  • Instance
  • Binding

Need support following set of operations

  • Load resource/Create
  • Get/List
  • Update
  • Delete

Tasks:

  • Add java model classes : model#issue
  • Implement feature code
  • Add unit tests
  • Add integration tests
@hrishin hrishin added the feature label Jan 3, 2018
@hrishin hrishin added this to the Sprint 143 milestone Jan 3, 2018
@hrishin hrishin changed the title Add support for service catalog fature Add support for service catalog feature Jan 3, 2018
@hrishin hrishin removed this from the Sprint 143 milestone Jan 4, 2018
@piyush-garg piyush-garg mentioned this issue Feb 28, 2018
Closed
25 tasks
@devang-gaur devang-gaur mentioned this issue Mar 1, 2019
Closed
10 tasks
@devang-gaur devang-gaur added the gsoc candidate for GSoC label Mar 1, 2019
@rohanKanojia
Copy link
Member

rohanKanojia commented Apr 7, 2019 •
edited
Loading

@dev-gaur : There is an extension of this api maintained by spring-boot team(maintained by @iocanel ):

https://github.com/snowdrop/servicecatalog-java-api

Did you check this before marking this as a potential gsoc task? Could you please explain what kind of integration are we demainding here? In my opinion, it doesn't make much sense.

@theexplorist
Copy link
Contributor

theexplorist commented Apr 7, 2019 •
edited
Loading

@dev-gaur @rohanKanojia fabric8io/kubernetes-model#225 This may clarify it! In comments the extension is mentioned!

@devang-gaur
Copy link
Contributor

@rohanKanojia Let's close this one if there's no scope for any work here.

@iocanel
Copy link
Member

iocanel commented Apr 8, 2019

There is no need to reimplement: https://github.com/snowdrop/servicecatalog-java-api

I am discussing the possibility of merging into this project.

@rohanKanojia
Copy link
Member

Okay, Ioannis got approval for moving service catalog client into our repository. I think we should add that api as another module in our project.

@kunal-kushwaha kunal-kushwaha mentioned this issue Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunal-kushwaha kunal-kushwaha

Labels
feature gsoc candidate for GSoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for service catalog client kunal-kushwaha/kubernetes-client
6 participants
@iocanel @devang-gaur @rohanKanojia @hrishin @theexplorist @kunal-kushwaha