Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test in CI that we're in sync with problem-specifications #1721

Open
senekor opened this issue Sep 9, 2023 · 2 comments
Open

Test in CI that we're in sync with problem-specifications #1721

senekor opened this issue Sep 9, 2023 · 2 comments

Comments

@senekor
Copy link
Contributor

senekor commented Sep 9, 2023

...but we don't want our CI to break by upstream changes.

So we pin a version of problem-specifications as a submodule. The updating workflow would then be: Pull the submodule, run the test generator over all implemented exercises, fix what's broken (hopefully all caught by CI), and open a PR.

This is blocked by configlet being able to use a pinned version of problem-specifications, see exercism/configlet#816.

Probably in a later step, we could add a CI cron job to check for upstream changes and open an issue (or even a PR with the update already done!)

@senekor
Copy link
Contributor Author

senekor commented Dec 15, 2023

Reading the linked issue in the configlet repo again, we're not really blocked. If there is no movement on the configlet side, we can do it ourselves with little effort.

The only thing that's missing now is for the repo to actually be in sync with problem-specifications. Still a bunch of exercises left to sync.

@senekor
Copy link
Contributor Author

senekor commented Dec 16, 2023

Maybe this should be split up into two conceptual tests:

  • configlet sync is happy
  • running the test generator over all exercises that use it is a noop

Importantly, the second point can be implemented already. This doesn't need to wait until all exercises are synced / uplifted to the test generator. Maybe it doesn't even make sense to use the test generator for some exercises that don't come from problem-specifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant