--no-colors does not disable all colorized output

[scop]

🔧 Summary

Per the subject.

Lefthook version

1.5.2

Steps to reproduce

lefthook --no-colors run pre-commit --all-files

Expected results

No colors in output, just the configured terminal colors.

Actual results

Some colors remain, e.g. in the lefthook icon and the last summary line status icon.

Possible Solution

Logs / Screenshots

[mrexox]

Hey! --no-colors option wasn't supposed to disable icons 🤔 Do you disagree?

[scop]

It is currently documented as "disable colored output", so I thought it'd apply to all colors, no matter the implementation detail whether that's marked up or part of an icon.

With the current description I'd say this is a bug, but the fix might be to fix the description, for example "disable colored text output".

Then again, I don't know if there's a deeper reasoning why colors are disabled, and if it's about colors or some escape sequences that might not work nicely everywhere. But if it's about colors in particular, then I'd think colors should be disabled no matter where they come from.

Not a biggie at all though, just a bit surprising.

[sanmai-NL]

@mrexox The text is also colored.

[mrexox]

Hmm, probably some subcommands use colorized output?

[mrexox]

I hope that PR #812 will fix the color-specific issues