-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lastIndexOf
in sourcemap-register.js
causes Github to flag Incorrect suffix check
#320
Comments
Searching for https://github.com/evanw/node-source-map-support/search?q=lastIndexOf Are you sure that the code is from this package, and could you point me to the code in question in that case? |
as far as I can tell... it was in a sourcemap-register.js file which I think was generated by node-source-map-support ? I am not clear on where
ncc build src/main.ts --out dist/main --source-map && ncc build src/post.ts --out dist/post --source-map adding |
The heuristic looks like it might apply to It looks like it may be this block its complaining about: node-source-map-support/source-map-support.js Lines 334 to 341 in 7b5b81e
Copied from v8 almost 9 years ago 😅 |
I'm seeing the same issue specifically pointed at
The flagged code is the minified version of what @calebboyd referenced above: |
I think this
sourcemap-register.js
file is an output of this module:https://raw.githubusercontent.com/gradle/gradle-build-action/aeb3e0fcd750be80d74f07ee94363abdf2b51020/dist/post/sourcemap-register.js
which contains this:
Which causes Github advanced security to issue this "high" severity error:
https://codeql.github.com/codeql-query-help/javascript/js-incorrect-suffix-check/
Would be great if you can confirm if this is related to node-source-map-support
If it is related, can you add the suggested fix here: https://codeql.github.com/codeql-query-help/javascript/js-incorrect-suffix-check/
to avoid the error from GH advanced security. :)
The text was updated successfully, but these errors were encountered: