Bug recurred: error: Could not resolve "fs"

[n0pj]

The bug has recurred on my Mac. #90
It happened when I updated esbuild from 0.12.7 to 0.12.8.

node -v
14.15.0

I using esbuild with gulp, browserify.

    // ...
    return esbuild
      .build({
        define: { 'process.env.NODE_ENV': mode },
        target: 'es6',
        entryPoints: files,
        bundle: true,
        outdir: `${buildDirectorySrc}/scripts`,
        minify: !isDev,
        sourcemap: isDev,
        plugins: [sassPlugin()]
      })
      .catch(e => {
        console.log(e)
        // process.exit(1)
      })

[lxsmnsyc]

Have you tried checking https://esbuild.github.io/getting-started/#bundling-for-the-browser

[evanw]

This is currently unactionable. There isn't enough information here to be able to reproduce it so it can be fixed. Please provide a way to reproduce the issue.

[evanw]

Closing due to lack of a response.

[johrstrom]

Hi can I open this back up? I'm getting it out of the handlebars package while building for the browser.

[ERROR] Could not resolve "fs"

    node_modules/handlebars/lib/index.js:17:19:
      17 │   var fs = require('fs');
         ╵                    ~~~~

https://github.com/handlebars-lang/handlebars.js/blob/a9fe6d5a03cbb4a58ec80806d08c0602435c974c/lib/index.js#L18

Admittedly I'm a bit new the javascript toolchains so I don't know to force this dependency to build one way or another. I don't have a build.js - I'm just running this one command:

esbuild app/javascript/packs/*.* --bundle --sourcemap --loader:.svg=file --outdir=app/assets/builds

[evanw]

I assume you are bundling for node because fs is a node-specific API. In that case you should use --platform=node. This is documented: https://esbuild.github.io/getting-started/#bundling-for-node. Or you can just do --external:fs to skip bundling fs if you are bundling for the browser and the code causing the problem is never used (you obviously can’t actually use fs in the browser because it’s a node-only API). Anyway this is not a bug with esbuild. You just need to configure esbuild correctly.

[johrstrom]

Or you can just do --external:fs to skip bundling fs

This is exactly what I'm looking for. Thank you so much!