Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the install_pyspec_test CI check #3894

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Fix the install_pyspec_test CI check #3894

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f600728
Fix the install_pyspec_test CI check
jtraglia Aug 22, 2024
a9a1d9a
Try no restore/save cache
jtraglia Aug 22, 2024
92a801a
Only disable restore_pyspec_cached_venv
jtraglia Aug 22, 2024
4850a28
Remove line to pull new py_arkworks wheel
jtraglia Aug 22, 2024
562798d
Update cache version and add back line
jtraglia Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ commands:
description: "Restore the cache with pyspec keys"
steps:
- restore_cached_venv:
venv_name: v24-pyspec
venv_name: v25-pyspec
reqs_checksum: cache-{{ checksum "setup.py" }}-{{ checksum "requirements_preinstallation.txt" }}
save_pyspec_cached_venv:
description: Save a venv into a cache with pyspec keys"
steps:
- save_cached_venv:
venv_name: v24-pyspec
venv_name: v25-pyspec
reqs_checksum: cache-{{ checksum "setup.py" }}-{{ checksum "requirements_preinstallation.txt" }}
venv_path: ./venv
restore_deposit_contract_tester_cached_venv:
Expand Down Expand Up @@ -80,15 +80,15 @@ jobs:
- ~/specs-repo
install_pyspec_test:
docker:
- image: ethpandaops/circleci-python-rust:latest
- image: cimg/python:3.12.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parithosh could you help confirm it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I pinged @kevaundray and asked him to publish pre-built wheels for Python 3.12 to py_arkworks. You can see these here: https://pypi.org/project/py-arkworks-bls12381/#files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah amazing! I only added rust to get around the py_arkworks_bls12381. If that has been fixed, i agree we should switch back to the official python image.

working_directory: ~/specs-repo
steps:
- restore_cache:
key: v3-specs-repo-{{ .Branch }}-{{ .Revision }}
- restore_pyspec_cached_venv
- run:
name: Install pyspec requirements
command: make install_test && make preinstallation
command: make install_test
- save_pyspec_cached_venv
test-phase0:
docker:
Expand Down