Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the install_pyspec_test CI check #3894

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Aug 22, 2024

It looks like this CI test was accidentally broken in this PR. We just need to update the cache version.

I'm not sure why Rust (via ethpandaops/circleci-python-rust:latest) is necessary. I don't think it should be. If there's an issue, I'm hoping the CI check will tell me which package needs it. (edit: Oh it's py_arkworks_bls12381, that makes sense. But this is a mistake. It only provides pre-built wheels up to python 3.11, we can fix this).

Also, there's no need to call make preinstallation as preinstallation is a dependency of install_test:

consensus-specs/Makefile

Lines 107 to 115 in ad91a83

# check the setup tool requirements
preinstallation:
python3 -m venv venv && \
. venv/bin/activate && \
python3 -m pip install -r requirements_preinstallation.txt
install_test: preinstallation
. venv/bin/activate && \
python3 -m pip install -e .[lint,test]

@@ -80,15 +80,15 @@ jobs:
- ~/specs-repo
install_pyspec_test:
docker:
- image: ethpandaops/circleci-python-rust:latest
- image: cimg/python:3.12.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parithosh could you help confirm it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I pinged @kevaundray and asked him to publish pre-built wheels for Python 3.12 to py_arkworks. You can see these here: https://pypi.org/project/py-arkworks-bls12381/#files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah amazing! I only added rust to get around the py_arkworks_bls12381. If that has been fixed, i agree we should switch back to the official python image.

@hwwhww hwwhww merged commit ca04b1e into ethereum:dev Aug 22, 2024
26 checks passed
@jtraglia jtraglia deleted the fix-install_pyspec_test branch August 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants