Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7732: Modify ExecutionPayloadEnvelopeByRoot #3890

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

StefanBratanov
Copy link
Contributor

  • Made ExecutionPayloadEnvelopeByRoot plural to be consistent with other req/resp methods
  • Renamed MAX_REQUEST_PAYLOAD to MAX_REQUEST_PAYLOAD to be consistent with MAX_REQUEST_BLOCKS
  • Added MAX_REQUEST_PAYLOADS to mainnet/minimal configs

Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but with two small nits. Thanks!

specs/_features/eip7732/p2p-interface.md Outdated Show resolved Hide resolved
specs/_features/eip7732/p2p-interface.md Outdated Show resolved Hide resolved
@StefanBratanov
Copy link
Contributor Author

LGTM but with two small nits. Thanks!

Thanks, commited those.

@hwwhww hwwhww merged commit a95195b into ethereum:dev Aug 29, 2024
26 checks passed
@StefanBratanov StefanBratanov deleted the eip_7732_modify branch August 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants