Replace recover_data with recover_polynomialcoeff
#3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
force-pushed
the
kw/simplify-recover-data
branch
from
8b0a05d to
4907658
Compare
|
Would wait for #3819 as it makes that method even simpler |
kevaundray
commented
Jun 26, 2024
jtraglia
changed the title
recover_data with recover_polynomial_coeffrecover_data with recover_polynomialcoeff
jtraglia
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to simplify recovery. Previously, we reconstructed the extended blob and converted that to a polynomial in coefficient form. Instead, we can reconstruct the polynomial and return that. It allows us to skip the conversion. Also, this PR adds a new
compute_cells_and_kzg_proofs_polynomialcoefffunction which is used bycompute_cells_and_kzg_proofsandrecover_cells_and_kzg_proofs.