eip7594: Remove proof parameter from recover_cells_and_kzg_proofs
#3819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the proof parameter from
recover_cells_and_kzg_proofs
since computing individual proofs is only favourable when there are one to five cells missing. Since most clients will start recovery when half of the cells are missing, this functionality would not be useful in practice for our usecases.We could leave it there, ignore it and have implementations decide, but note that we do need to validate the proofs are valid according to the current API, so its not
free
.This means we are essentially validating the proofs twice, since a user should only pass in proofs + cells that they have passed to
verify_cell_kzg_proof
beforehand. It is not a security concern if these proofs are not validated since the receiver will validate them, but given that fk20 takes about 200ms to compute all of the proofs on a single thread, I don't think it makes sense to try and optimize for the seemingly rare case of one to five missing cells/proofs