Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add correct type casts to eip7594 functions #3697

Closed
wants to merge 26 commits into from

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Apr 18, 2024

cc @hwwhww

This PR resolves all of the errors for eip7594.

I applied a workarounf for the error error: Invalid base class "List" -- Happy to revert if there is a better solution.

@kevaundray kevaundray changed the title Add eip7594 to pylint checks chore: Add eip7594 to pylint checks Apr 18, 2024
@kevaundray
Copy link
Contributor Author

The invalid base class error comes from ExtendedMatrix | List[Cell, MAX_BLOBS_PER_BLOCK * NUMBER_OF_COLUMNS]

I suspect that the issue arises because the size of the list is not a literal

@kevaundray kevaundray force-pushed the kw/add-eip7594-to-pylint branch from 6651612 to 9c9f8f1 Compare April 18, 2024 18:58
@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 19, 2024
@kevaundray kevaundray changed the title chore: Add eip7594 to pylint checks chore: Add correct type casts to eip7594 functions Apr 22, 2024
@kevaundray
Copy link
Contributor Author

I've removed the check from the CI, since this PR is very prone to having merge conflicts. There seems to be an underlying issue that I've yet to investigate (CI timing out)

@asn-d6 asn-d6 force-pushed the kw/add-eip7594-to-pylint branch from 1cd63df to 8ec433c Compare April 29, 2024 11:55
@ralexstokes
Copy link
Member

is this PR still active? or can we close for being stale? looks like the problem this PR addresses has been handled in other ways since?

@kevaundray
Copy link
Contributor Author

is this PR still active? or can we close for being stale? looks like the problem this PR addresses has been handled in other ways since?

I've merged in most of the changes for this in separate PRs, we haven't enabled type casts because the CI kept timing out (happy to close and re-open a new PR when I have more time to investigate the typing issue -- the code has been updated since)

@Aga92-92
Copy link

.

1 similar comment
@Aga92-92
Copy link

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants