Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: For compute_kzg_proof_multi remove remainder polynomial when in monomial form #3696

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

kevaundray
Copy link
Contributor

Computing the quotient polynomial in monomial form means we can ignore the remainder term. In #3695 I can extend the comments to explain the transformation. Putting this up for now, so that we can check the performance diff.

@kevaundray kevaundray changed the title For compute_kzg_proof_multi remove remainder polynomial when in monomial form chore: For compute_kzg_proof_multi remove remainder polynomial when in monomial form Apr 18, 2024
@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 19, 2024
@hwwhww hwwhww requested a review from asn-d6 April 19, 2024 06:35
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

Agreed that we should doc this optimization in some way. Arkworks docs it like this.

Seems like also the "Compute the quotient polynomial directly in evaluation form" comment above is wrong? Anyhow, let's handle docs in the other PR.

@kevaundray
Copy link
Contributor Author

Good one!

Agreed that we should doc this optimization in some way. Arkworks docs it like this.

Seems like also the "Compute the quotient polynomial directly in evaluation form" comment above is wrong? Anyhow, let's handle docs in the other PR.

Yep! #3695 fixes the comments in that function -- once we merge it in, I can note that we do not need to compute the remainder polynomial

@kevaundray
Copy link
Contributor Author

Merged dev into the branch updated the comment to briefly explain why we can remove the computation for r(x)

@jtraglia jtraglia merged commit 9279848 into ethereum:dev Apr 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants