Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisk: Move non-preset values to config #3482

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

dapplion
Copy link
Collaborator

Preset values should be those that affect types or other build time data structures.

Both WHISK_EPOCHS_PER_SHUFFLING_PHASE and WHISK_PROPOSER_SELECTION_GAP do not affect any data structure and are useful to tweak in tests to speed up their runtime. Setting WHISK_PROPOSER_SELECTION_GAP to a value >= WHISK_EPOCHS_PER_SHUFFLING_PHASE - 1 disables tracker shuffling

@asn-d6
Copy link
Contributor

asn-d6 commented Aug 20, 2023

Thanks!

@asn-d6 asn-d6 merged commit 0b751fc into ethereum:dev Aug 20, 2023
@hwwhww
Copy link
Contributor

hwwhww commented Aug 20, 2023

@dapplion

Also need to update the presets/<minimal,mainnet>/whisk.yaml files and config files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants