Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BLOB_SIDECAR_SUBNET_COUNT to 6 in line with max blobs limit update and add it to config #3416

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 12, 2023

Since the max blobs limit has been raised, may be subnet count can be bumped too for now

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@hwwhww
Copy link
Contributor

hwwhww commented Jun 12, 2023

If BLOB_SIDECAR_SUBNET_COUNT should always be the same size as MAX_BLOBS_PER_BLOCK, should we just use MAX_BLOBS_PER_BLOCK directly and remove BLOB_SIDECAR_SUBNET_COUNT?

Edited: Also, consider moving it from the "constants" category if it's not a true constant.

@g11tech
Copy link
Contributor Author

g11tech commented Jun 12, 2023

If BLOB_SIDECAR_SUBNET_COUNT should always be the same size as MAX_BLOBS_PER_BLOCK, should we just use MAX_BLOBS_PER_BLOCK directly and remove BLOB_SIDECAR_SUBNET_COUNT?

Edited: Also, consider moving it from the "constants" category if it's not a true constant.

It may be a constant future onwards but may be we can keep it same to begin with

@ppopth
Copy link
Member

ppopth commented Jun 12, 2023

If BLOB_SIDECAR_SUBNET_COUNT should always be the same size as MAX_BLOBS_PER_BLOCK, should we just use MAX_BLOBS_PER_BLOCK directly and remove BLOB_SIDECAR_SUBNET_COUNT?

Theoretically, they can be different. For example, if the protocol is run in a very high-bandwidth network, MAX_BLOBS_PER_BLOCK can be like 128. While, if BLOB_SIDECAR_SUBNET_COUNT is also 128, the beacon node has to maintain the state for all 128 subnets unnecessarily.

This is analogous to MAX_COMMITTEES_PER_SLOT and ATTESTATION_SUBNET_COUNT. They are both 64.

@hwwhww
Copy link
Contributor

hwwhww commented Jun 12, 2023

I moved BLOB_SIDECAR_SUBNET_COUNT to the networking config (210c482) as we discussed in the 4844 call today.

@djrtwo djrtwo merged commit 4dbb454 into ethereum:dev Jun 12, 2023
@hwwhww hwwhww changed the title Update blob side car subnet count to 6 in line with max blobs limit update Update BLOB_SIDECAR_SUBNET_COUNT to 6 in line with max blobs limit update and add it to config Jun 12, 2023
@hwwhww hwwhww changed the title Update BLOB_SIDECAR_SUBNET_COUNT to 6 in line with max blobs limit update and add it to config Update BLOB_SIDECAR_SUBNET_COUNT to 6 in line with max blobs limit update and add it to config Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants