Simplify commitee weight computation #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
This is the original PR https://github.com/ethereum/consensus-specs/pull/2730/files
No discussion of why the indirection and intermediate vars... I think was just an oversight
Approved
2 tasks
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
May 5, 2023
Optimizations from ethereum/consensus-specs#3246 avoid a couple unnecessary divisions when calculating proposer boost.
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
May 9, 2023
Optimizations from ethereum/consensus-specs#3246 avoid a couple unnecessary divisions when calculating proposer boost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify unnecessary divisions since there is no possible overflow