More capella tests #3227
Merged
More capella tests #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Jan 26, 2023
| yield 'blocks', [signed_block] | ||
| yield 'post', state | ||
|
|
||
| validator = state.validators[validator_index] |
There was a problem hiding this comment.
maybe write a comment that withdrawals happen before deposits so no partial withdrawal is made in the prior transition (just to make explicit)
| state.validators[validator_index], state.balances[validator_index]) | ||
|
|
||
| # Getting attester rewards and getting partial withdrawals | ||
| for _ in range(2): |
There was a problem hiding this comment.
What is the 2 magic number? to go through all validators and thus partially withdraw this validator?
There was a problem hiding this comment.
I was thinking of 1 epoch for balance updates, 1 epoch for withdrawals + balance updates.
| pre_tag, | ||
| post_tag, | ||
| operation_type=OperationType.BLS_TO_EXECUTION_CHANGE, | ||
| operation_at_slot=fork_epoch * spec.SLOTS_PER_EPOCH - 1, |
There was a problem hiding this comment.
Shouldn't this fail because you can't include BLS_TO_EXECUTION_CHANGE operations before the fork?
There was a problem hiding this comment.
Ah good point, it should have been in eip4844 folder for testing capella -> eip4844 fork transition.
Co-authored-by: Danny Ryan <[email protected]>
hwwhww
force-pushed
the
more-capella-tests
branch
from
8e0bd44 to
a87f727
Compare
hwwhww
force-pushed
the
more-capella-tests
branch
from
a87f727 to
9ab1478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests of mixing top-ups and withdrawals, rename old test case