Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a process_bls_to_execution_change test case from staking-deposit-cli #3202

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Add a process_bls_to_execution_change test case from staking-deposit-cli #3202

merged 4 commits into from
Jan 13, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jan 10, 2023

cross-implementation verifies the SignedBLSToExecutionChange signature.

ralexstokes
ralexstokes reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea! how can we ensure this test is both here and in the staking-cli repo?

I'd be happy even if you could just link here to the test there in a comment

...s/core/pyspec/eth2spec/test/capella/block_processing/test_process_bls_to_execution_change.py Outdated Show resolved Hide resolved
ghost
ghost approved these changes Jan 11, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

ghost

This comment was marked as spam.

Sign in to view

@hwwhww
Copy link
Contributor Author

hwwhww commented Jan 11, 2023

@ralexstokes Thanks for the review!

how can we ensure this test is both here and in the staking-cli repo?
I'd be happy even if you could just link here to the test there in a comment

It was generated from ethereum/staking-deposit-cli#313 (not merge) - tests/test_cli/test_generate_bls_to_execution_change.py::test_existing_mnemonic_bls_withdrawal test case.

@hwwhww
Copy link
Contributor Author

hwwhww commented Jan 12, 2023

[DO NOT MERGE] pending on #3206

@djrtwo djrtwo mentioned this pull request Jan 13, 2023
Merged
4 tasks
@hwwhww hwwhww force-pushed the deposit-cli-testcase branch from 9e187d0 to a527390 Compare January 13, 2023 15:40
@hwwhww hwwhww merged commit 496e1d8 into dev Jan 13, 2023
@hwwhww hwwhww deleted the deposit-cli-testcase branch January 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes left review comments

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @djrtwo @ralexstokes