Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deneb crypto helpers test coverage #3258

Closed
6 tasks done
hwwhww opened this issue Feb 17, 2023 · 1 comment
Closed
6 tasks done

Deneb crypto helpers test coverage #3258

hwwhww opened this issue Feb 17, 2023 · 1 comment
Labels
scope:CI/tests/pyspec

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Feb 17, 2023 •
edited by dankrad
Loading

Currently, we don't have tests to cover these functions:

  • polynomial-commitments.md
    • verify_kzg_proof wrapper
    • compute_kzg_proof wrapper
    • verify_blob_kzg_proof
    • validate_kzg_g1: if b == G1_POINT_AT_INFINITY case
  • validator.md
    • get_blob_sidecar_signature
    • validate_blobs_and_kzg_commitments

Except for validate_kzg_g1, they are not used in the core protocol. Still, it's better to add unit tests for them.
@dankrad dankrad mentioned this issue Mar 6, 2023
Merged
@dankrad
Copy link
Contributor

dankrad commented Mar 12, 2023

Done in #3283

@dankrad dankrad closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dankrad @hwwhww