Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7600: Add EIPs 7623 & 7691 #9094

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Dec 5, 2024

EIP-7691 was SFI'd on ACDC#146 and EIP-7623 was SFI'd on ACDE#201

Signed-off-by: Tim Beiko <[email protected]>
@timbeiko timbeiko marked this pull request as ready for review December 5, 2024 17:56
@timbeiko timbeiko requested a review from eth-bot as a code owner December 5, 2024 17:56
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-meta labels Dec 5, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 5, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add EIPs 7623 & 7691 Update EIP-7600: Add EIPs 7623 & 7691 Dec 5, 2024
@eth-bot eth-bot enabled auto-merge (squash) December 5, 2024 17:57
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 5, 2024
@timbeiko
Copy link
Contributor Author

timbeiko commented Dec 5, 2024

Blocked by #9095

Copy link
Contributor

@abcoathup abcoathup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: match my notes

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

EIPS/eip-7600.md Outdated
* [EIP-7702](./eip-7702.md): Set EOA account code
* [EIP-7742](./eip-7742.md): Uncouple blob count between CL and EL

### EIPs Considered for Inclusion

* [EIP-7623](./eip-7623.md): Increase calldata cost
* [EIP-7762](./eip-7762.md): Increase MIN_BASE_FEE_PER_BLOB_GAS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove as of ACDC #147

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean to remove EIP-7762

EIPS/eip-7600.md Outdated
* [EIP-7685](./eip-7685.md): General purpose execution layer requests
* [EIP-7691](./eip-7691.md): Blob throughput increase
* [EIP-7702](./eip-7702.md): Set EOA account code
* [EIP-7742](./eip-7742.md): Uncouple blob count between CL and EL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove as of ACDC #147

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot previously approved these changes Dec 13, 2024
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled December 13, 2024 13:39

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) December 13, 2024 13:40
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit 5a663e1 (as a parent of c3d1415) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-meta w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants