Update EIP-4788: Move to Draft #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
- additional author - use block roots instead of state roots - key by slot - use of ring buffer in state - use header timestamps to derive slot numbers, rather than consume additional header space
ralexstokes
force-pushed
the
update-4788
branch
from
7163367 to
38e025c
Compare
github-actions
bot
added
s-draft
eth-bot
changed the title
github-actions
bot
added
w-ci
g11tech
reviewed
Apr 10, 2023
g11tech
reviewed
Apr 10, 2023
g11tech
reviewed
Apr 10, 2023
g11tech
reviewed
Apr 10, 2023
Co-authored-by: g11tech <[email protected]>
Co-authored-by: g11tech <[email protected]>
Co-authored-by: g11tech <[email protected]>
github-actions
bot
added
w-ci
Co-authored-by: g11tech <[email protected]>
|
The commit 7a98c7b (as a parent of ed1df6b) contains errors. |
g11tech
reviewed
Apr 11, 2023
EIPS/eip-4788.md
Outdated
| 1. set the value of the `ommers` field in the block to an RLP list with one element: the 32 byte [hash tree root](https://github.com/ethereum/consensus-specs/blob/dev/ssz/simple-serialize.md#merkleization) of the [beacon state](https://github.com/ethereum/consensus-specs/blob/dev/specs/bellatrix/beacon-chain.md#beaconstate) from the previous slot to this block. | ||
|
|
||
| 2. set the value of the `ommersHash` field in the block header to the Keccak256 hash of the `ommers` field. | ||
| 1. set 32 bytes of the execution block header after the `withdrawals_root` to the 32 byte [hash tree root](https://github.com/ethereum/consensus-specs/blob/dev/ssz/simple-serialize.md#merkleization) of the parent beacon block. |
There was a problem hiding this comment.
I think this link needs to be refered with a specific commit hash instead of the dev tag
lightclient
reviewed
Apr 11, 2023
lightclient
approved these changes
Apr 11, 2023
eth-bot
approved these changes
Apr 11, 2023
mkalinin
reviewed
Apr 12, 2023
| beacon_state_root = block.ommers[0] | ||
| sstore(HISTORY_STORAGE_ADDRESS, block.number, beacon_state_root) | ||
| start_timestamp = get_block(block_header.parent_hash).header.timestamp | ||
| start_slot = convert_to_slot(start_timestamp) |
There was a problem hiding this comment.
We can re-use nonce field to put a slot number into it allowing to avoid EL to be aware of timestamp to slot conversion. It also opens an opportunity to add SLOT EVM instruction in the future.
There was a problem hiding this comment.
yeah I wasn't sure if this was a new capability, e.g. post-4844 and if so then we can do something like what you suggest to also provide slot data with the root
djrtwo
reviewed
Apr 13, 2023
| type: Standards Track | ||
| category: Core | ||
| created: 2022-02-10 | ||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| Commit to the state root of the beacon chain in the `ommers` field in the post-merge execution block. Reflect the changes in the `ommersHash` field of the execution block header. | ||
| Commit to the (hash tree) root of each beacon chain block in the corresponding execution payload header. |
There was a problem hiding this comment.
Why the parenthesis? Might just actually also say "SSZ hash tree root"
| ``` | ||
|
|
||
| When using any slot value as a key to the storage, the value under consideration should be converted to 32 bytes with big-endian encoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also relevant: ethereum/consensus-specs#3319