Revamp Labels

[Pandapip1]

I volunteer to implement the following if the labels are created/updated (the description is in the sub-item):

• waiting: no recent activity
  • Description: The PR or issue has had no recent activity and will be closed soon.
  • Added in: Change stale threshold #5398
• waiting: walidator to pass
  • Description: The PR has eipw errors. Please fix them.
  • Added in: Cleanup CI & Add Automatic Error Labeling #5406
• waiting: htmlproofer to pass
  • Description: The PR has htmlproofer errors. Please fix them.
  • Added in Cleanup CI & Add Automatic Error Labeling #5406
• waiting: codespell to pass
  • Description: The PR has codespell errors. Please fix them.
  • Added in Cleanup CI & Add Automatic Error Labeling #5406
• waiting: EIP number
  • Description: The PR needs an editor to assign an EIP Number
  • Added in: Add Waiting on EIP Number Label #5412
• waiting: review needs attention
  • Description: The PR has a non-stale review by an editor or an author.
  • Tracked in Add certain labels automatically EIP-Bot#110
• waiting: author to review
  • Description: The PR requires author review.
  • Tracked in: Add certain labels automatically EIP-Bot#110
• waiting: editor to review
  • Description: The PR required editor review.
  • Tracked in: Add certain labels automatically EIP-Bot#110

Note: add these labels but do not remove the old ones yet

• classification: new EIP
  • Description: This PR creates a new EIP file
  • Supersedes newEIPFile
  • Added in: Use New Classification Labels #5413
• classification: update EIP
  • Description: This PR updates an existing EIP file
  • Supersedes updateEIP
  • Added in: Use New Classification Labels #5413
• classification: EIP status change
  • Description: This PR updates the status of an existing EIP file
  • Supersedes statusChange
  • Added in: Use New Classification Labels #5413

[Pandapip1]

@MicahZoltu feel free to create the labels and then tick off the boxes.

[MicahZoltu]

If we rename stale, I think the stale bot will break so that change will need to happen at the same time as a bot update.

waiting: needs editor review and waiting: needs author review both make obvious sense to me on what they should do, but it is unclear what waiting: review needs attention means. Does it just get thrown onto the PR anytime an author/editor reviews an EIP? What causes it to fall off?

[MicahZoltu]

I created the following just as placeholders for now, but I'm open to further iteration on names before we start to use them. Slightly different from the ones recommended by @Pandapip1 since I would like a bit more consistency in formatting. Changed "CI has errors" to "walidator to pass" to make it more clear which CI was having problems (we can have one for each CI that can reasonably fail).

waiting: author to review
waiting: editor to review
waiting: walidator to pass

[Pandapip1]

Sounds good to me.

[Pandapip1]

Does it just get thrown onto the PR anytime an author/editor reviews an EIP?

Yes.

What causes it to fall off?

Either a commit to the matching branch or the review comment getting marked as resolved.

[Pandapip1]

A lot of the labels are missing descriptions. Could you add them?

[MicahZoltu]

All of the labels created and descriptions added. For the stale label, I recommend we implement whatever bots we want to use the new waiting: no recent activity label and once they are live then we can remove the old stale label and move an PRs/issues with that label over to the new label.

[Pandapip1]

@MicahZoltu I have updated the list of labels.