Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back npm --save in installDeps.sh #3659

Closed
muxator opened this issue Oct 31, 2019 · 0 comments
Closed

Put back npm --save in installDeps.sh #3659

muxator opened this issue Oct 31, 2019 · 0 comments
Assignees
Milestone

Comments

@muxator
Copy link
Contributor

muxator commented Oct 31, 2019

We may need to activate again npm --save in installDeps.sh. Contextually, we may want to start tracking package-lock.json.

This would revert c4918ef, and partially negate what was done for #3396, but aligns better with current practices in the nodejs ecosystem.

Pragmatically speaking, this will allow users - if they want - to use npm-force-resolutions to manually fix security vulnerabilities.

We had a problem for that (see #3598), and given the fragmented nature of the
nodejs ecosystem it is reasonable to expect more issues like that one, so I think it's better to be prepared.

@muxator muxator self-assigned this Oct 31, 2019
@muxator muxator added this to the 1.8 milestone Oct 31, 2019
@muxator muxator assigned muxator and unassigned muxator Nov 1, 2019
@muxator muxator closed this as completed in 9ee131c Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant