-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server level feature gate #18023
Comments
while kubernetes/enhancements#4610 is still in review, I think there is no much contention regarding server level feature gate. we can get started on the implementation. |
Thanks @siyuanfoundation for the heads up! Happy to contribute to this feature :) Looking forward to it! |
Can we wait for approvals for the KEP so the implementation done by contributors don't need to be updated when the design details are changed frustrating the contributors? |
/cc @YoyinZyc |
What would you like to be added?
Add the Kubernetes style feature gate framework into etcd to gate future feature enhancement.
Users would be able to turn features on or off for the single server and query feature enablement in a consistent way.
This issue is for tracking KEP-4578.
Tasks in this KEP include
pkg/
: featuregate: adds EtcdServer.FeatureEnabled interface. #18062.--feature-gates
flag added: Add "server-feature-gates" flag. #18279, Add config file field for feature-gates flag. #18365.--experimental
server level features to feature gates without removing the old flags.List of features to migrate:
experimental-stop-grpc-service-on-defrag
: migrate experimental-stop-grpc-service-on-defrag flag to feature gate. #18359experimental-enable-distributed-tracing
: migrate--experimental-enable-distributed-tracing
flag to feature gate #19050experimental-initial-corrupt-check
: KEP-4578: migrate experimental-initial-corrupt-check flag to feature gate. #18478experimental-compact-hash-check-enabled
: migrate experimental-compact-hash-check-enabled to feature gate. #19053experimental-peer-skip-client-san-verification
: migrate experimental-peer-skip-client-san-verification flag to feature gate #19062experimental-enable-lease-checkpoint
andexperimental-enable-lease-checkpoint-persist
: KEP-4578: migrate experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag to feature gate. #18479experimental-memory-mlock
: migrate experimental-memory-mlock flag to feature gate #19061experimental-txn-mode-write-with-shared-buffer
: migrate experimental-txn-mode-write-with-shared-buffer flag to feature gate #19063Why is this needed?
To make it easier to add and use new features in etcd.
Please refer to kubernetes/enhancements#4578 for more details.
The text was updated successfully, but these errors were encountered: