Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: etcd > v3.3.13, <= v3.3.20 (latest v3.3) doesn't compile #11721

Closed
utrack opened this issue Mar 24, 2020 · 6 comments
Closed

backport: etcd > v3.3.13, <= v3.3.20 (latest v3.3) doesn't compile #11721

utrack opened this issue Mar 24, 2020 · 6 comments
Labels
stale

Comments

@utrack
Copy link

utrack commented Mar 24, 2020 •
edited
Loading

etcd v3.3.15 to v3.3.20 use gRPC API that was renamed in [email protected].
Right now etcd doesn't compile when not using modules, or if current module or any child module had used [email protected] or higher.

Problem was fixed in #11564, but it wasn't backported to v3.3 as I see.

Refs #11650 #11707
@PatrLind PatrLind mentioned this issue Apr 2, 2020
Closed
@utrack utrack mentioned this issue Apr 5, 2020
Closed
@utrack
Copy link
Author

utrack commented Apr 5, 2020

@gyuho sorry for ping, pinging as you seem to be the person responsible for releases (?)

@utrack utrack mentioned this issue Apr 9, 2020
Closed
@utrack utrack changed the title etcd <= v3.3.19 (latest v3.3) doesn't compile etcd > v3.3.13, <= v3.3.20 (latest v3.3) doesn't compile Apr 15, 2020
@utrack
Copy link
Author

utrack commented Apr 28, 2020 •
edited
Loading

JFYI - we at @ozonru forked v3.3.20 and applied the patch; we'll be maintaining this fork until the patch is merged to some release.
https://github.com/ozonru/etcd/releases/tag/v3.3.20-grpc1.27.1

@philips philips changed the title etcd > v3.3.13, <= v3.3.20 (latest v3.3) doesn't compile backport: etcd > v3.3.13, <= v3.3.20 (latest v3.3) doesn't compile Apr 28, 2020
@MilosSimic
Copy link

@utrack Thank you so much man! this fork worked for me with new grpc versions and etcd v3.3.20!!

@utrack
Copy link
Author

utrack commented May 25, 2020

@gyuho ping

@utrack utrack mentioned this issue May 27, 2020
Closed
@cfc4n cfc4n mentioned this issue Jun 24, 2020
Closed
@vtolstov
Copy link

gentle ping...

@zouyee zouyee mentioned this issue Aug 31, 2020
Closed
@stale
Copy link

stale bot commented Nov 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 18, 2020
@stale stale bot closed this as completed Dec 9, 2020
@leoryu leoryu mentioned this issue Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vtolstov @utrack @MilosSimic