Remove unnecessary dependence on jQuery

[ghost]

I changed two lines in ng-table and now I can use it without jQuery.

I don't have time to make a pull-request yet, but I hope I will find time in the next days.

Basically I change a line el = $(item) to 'el = anguler.element(item)' and replaced element.filter("thead") .remove(); with element.find("thead") .remove();

In the examples jQuery is often used for a loading layer. This is not the angular way of live IMHO:

        .directive('loadingContainer', function () {
            return {
                restrict: 'A',
                scope: false,
                link: function(scope, element, attrs) {
                    var loadingLayer = $('<div class="loading"></div>').appendTo(element);
                    $(element).addClass('loading-container');
                    scope.$watch(attrs.loadingContainer, function(value) {
                        loadingLayer.toggle(value);
                    });
                }
            };
        })

This could be replaced with something like:

        .directive('loadingContainer', function () {
            return {
                restrict: 'A',
                scope: false,
                template: '<div class="loading-container><div class="loading" ng-show="isLoading"></div></div>'
                link: function(scope, element, attrs) {
                    scope.$watch(attrs.loadingContainer, function(value) {
                        scope.isLoading = attrs.loadingContainer === "loading"
                    });
                }
            };
        })

or even simplier. I don't want to include the big old jquery for that if angular can handle that itself :)

Are there any reason why jQuery is really needed?

Nice module anyway!
Greets,
maklemenz

[esvit]

It will work without jQuery only when will be fixed bug angular/angular.js#1459
jQuery needs only for correct template compilation $('<tr>...</tr>')

[ghost]

Related pull request: angular/angular.js#3647

[WhiteMarlin]

I proceeded as did maklemenz in the original post; but in addition to the two lines he mentioned, I also changed the line

headerTemplate = $compile("<thead ng-include=\"templates.header\"></thead>")(scope);

to

headerTemplate = [$compile("<table><thead ng-include=\"templates.header\"></thead></table>")(scope)[0].tHead];

to work around the $compile issue.

[uxmaster]

I think it's fixed in 1.2.13, see angular/angular.js@31c450b