Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: browser testing is failing sometimes #18548

Closed
1 task
aladdin-add opened this issue Jun 3, 2024 · 9 comments · Fixed by #18558 or #18759
Closed
1 task

ci: browser testing is failing sometimes #18548

aladdin-add opened this issue Jun 3, 2024 · 9 comments · Fixed by #18558 or #18759
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion blocked This change can't be completed until another issue is resolved bug ESLint is working incorrectly infrastructure Relates to the tools used in the ESLint development process

Comments

@aladdin-add
Copy link
Member

aladdin-add commented Jun 3, 2024

ESLint version

main

What problem do you want to solve?

2c8fd34 did not fully fix the browser testing - it's still sometimes failing - e.g. https://github.com/eslint/eslint/actions/runs/9353577317/job/25744423567

========= Your concise report ==========
chrome-headless-shell (v125.0.6422.112) on linux
❌ Failed to setup tests, no tests found

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@aladdin-add aladdin-add added bug ESLint is working incorrectly infrastructure Relates to the tools used in the ESLint development process blocked This change can't be completed until another issue is resolved labels Jun 3, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 3, 2024
@aladdin-add aladdin-add moved this from Needs Triage to Blocked in Triage Jun 3, 2024
@aladdin-add aladdin-add added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 3, 2024
@fasttime
Copy link
Member

fasttime commented Jun 3, 2024

Just tried running Karma and it still works. I don't recall it giving any headaches.

@aladdin-add
Copy link
Member Author

I'm not surprised - Karma is very stable and has very few updates. I'm fine to switching back as we don't really need any advanced features, karma is already sufficient :)

@mdjermanovic
Copy link
Member

Karma was working great for our simple use case, but is now deprecated so we'd likely need to switch from Karma sooner or later anyway.

@github-project-automation github-project-automation bot moved this from Blocked to Complete in Triage Jun 12, 2024
@aladdin-add aladdin-add reopened this Aug 6, 2024
@aladdin-add
Copy link
Member Author

it's happening again: https://github.com/eslint/eslint/actions/runs/10260943448/job/28387817330?pr=18754

@christian-bromann can you take a look, thanks! 🙏

@christian-bromann
Copy link
Contributor

@aladdin-add looking into it.

@christian-bromann
Copy link
Contributor

@aladdin-add I raised a PR, mind taking a look?

@christian-bromann
Copy link
Contributor

Please keep me posted if you continue to see unreliable test runs. Thank you!

@aladdin-add
Copy link
Member Author

aladdin-add commented Aug 9, 2024

@christian-bromann In rare cases, it can still be happening(https://github.com/eslint/eslint/actions/runs/10313769226/job/28551070874):

Execution of 1 workers started at 2024-08-09T04:44:40.372Z

[0-0] RUNNING in chrome - file:///tests/lib/linter/linter.js
[0-0]  Error:  Test failed due to following error(s):
  - ignore.js?v=a53bdd1a: Failed to load resource: the server responded with a status of 504 (Outdated Optimize Dep)

  - escape-string-regexp.js?v=fee7ba7f: Failed to load resource: the server responded with a status of [50](https://github.com/eslint/eslint/actions/runs/10313769226/job/28551070874#step:5:51)4 (Outdated Optimize Dep)

  - natural-compare.js?v=a894a6e8: Failed to load resource: the server responded with a status of 504 (Outdated Optimize Dep)

[0-0] FAILED in chrome - file:///tests/lib/linter/linter.js

should have been fixed in webdriverio/webdriverio#13331?

@christian-bromann
Copy link
Contributor

Not sure, however we are releasing v9 of WebdriverIO next week which comes with some performance improvements for the component testing part which I hope will resolve this problem and make pipelines more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion blocked This change can't be completed until another issue is resolved bug ESLint is working incorrectly infrastructure Relates to the tools used in the ESLint development process
Projects
Archived in project
4 participants