Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Alignment of search bar cancel icon on the documentation page is broken #606

Closed
1 task done
zaryanz opened this issue Jul 25, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
accepted bug Something isn't working

Comments

@zaryanz
Copy link

zaryanz commented Jul 25, 2024

URL(s)

https://eslint.org/docs/latest/

What did you do?

This bug can be reproduced by searching for something in the search bar.
Tested on Firefox 128.0.2 (64-bit), Google Chrome 126.0.6478.183 (Official Build) (arm64) - macOS Ventura 13.3.1

What did you expect to happen?

Ideally, the cancel icon should be center aligned.

What actually happened?

Currently, the cancel icon appears at the bottom of the search bar, which does not look right.
Screenshot 2024-07-25 at 12 45 23 PM

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@zaryanz zaryanz added the bug Something isn't working label Jul 25, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 25, 2024
@harish-sethuraman
Copy link
Member

Can you send similar fixes as https://github.com/eslint/eslint/pull/18682/files?

@harish-sethuraman harish-sethuraman moved this from Needs Triage to Ready to Implement in Triage Jul 25, 2024
@zaryanz
Copy link
Author

zaryanz commented Jul 25, 2024

Sure thing. Thanks for providing the reference!
I'll be raising a PR for the same shortly.

@amareshsm
Copy link
Member

@zaryanz Thanks for pointing out the issue. It has already been fixed in #603 but it hasn't been deployed yet.

@github-project-automation github-project-automation bot moved this from Ready to Implement to Complete in Triage Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants