You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just discovered the project, and it's really great to make custom eslint configurations. Really, an incredible job, well done 👏
I realized that you added support for eslint-plugin-node. which is cool, but this plugin has not been maintained for a while. People are starting to migrate to eslint-plugin-n which is a fork. And it's possible that a repo transfer will be done soon :
I don't know exactly all the changes between the two repositories, all I know is that many things are in common.
So we have two choices, either totally drops the first one for the second plugin, or support both. I would be more in favor of dropping eslint-plugin-node.
I can't promise anything because I'm a little short on time right now, but I'm willing to propose a PR after I get your opinion.
Thanks again for this fabulous project which is a life saver!
The text was updated successfully, but these errors were encountered:
For now, I would just prefer to support both
So just add the new plugin and run the generate script (see package.json scripts)
Then ignore ALL errors that were thrown by the generate tool and revert all non plugin related changes
Then check if everything coming from the plugin looks fine
Hey !
I just discovered the project, and it's really great to make custom eslint configurations. Really, an incredible job, well done 👏
I realized that you added support for
eslint-plugin-node
. which is cool, but this plugin has not been maintained for a while. People are starting to migrate toeslint-plugin-n
which is a fork. And it's possible that a repo transfer will be done soon :mysticatea/eslint-plugin-node#341
I don't know exactly all the changes between the two repositories, all I know is that many things are in common.
So we have two choices, either totally drops the first one for the second plugin, or support both. I would be more in favor of dropping
eslint-plugin-node
.I can't promise anything because I'm a little short on time right now, but I'm willing to propose a PR after I get your opinion.
Thanks again for this fabulous project which is a life saver!
The text was updated successfully, but these errors were encountered: