Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that there are spaces in the file name. (filename_.svg) #248

Closed
forejerk opened this issue Jul 27, 2021 · 3 comments
Closed

It seems that there are spaces in the file name. (filename_.svg) #248

forejerk opened this issue Jul 27, 2021 · 3 comments

Comments

@forejerk
Copy link

forejerk commented Jul 27, 2021

Hi. weather-icons is a great project.
but It seems that there are spaces in the file name.

image

I found this ? while incorporating weather-icons into emoji-mart-vue.
Some icon files cannot be loaded because there is a space character inserted between the extension and the file name.
The file path in values/weathericons.xml is fine.

image

@fox91
Copy link
Collaborator

fox91 commented Jul 28, 2021

Hi @ReefLE, unfortunately the SVG on this project aren't perfect on a lot of aspect (not only on the name).
I'm currently working on version 3.* with this and other issue fixed.
If this issue cause you trouble feel free to submit a PR.

@Travelbacon
Copy link
Contributor

I had today issues with the white spaces. And as you can see, I made a small PR.

@fox91
Copy link
Collaborator

fox91 commented Aug 1, 2021

Hi @Travelbacon, I've merged your PR.
Thanks

@fox91 fox91 closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants