Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxLookup: to check if can read txnIndex from TxLookup idx instead of calc #13156

Open
AskAlexSharov opened this issue Dec 18, 2024 · 0 comments · May be fixed by #13157
Open

TxLookup: to check if can read txnIndex from TxLookup idx instead of calc #13156

AskAlexSharov opened this issue Dec 18, 2024 · 0 comments · May be fixed by #13157
Assignees
Labels
erigon3 imp2 Medium importance

Comments

@AskAlexSharov
Copy link
Collaborator

To not calc txnIndex by read+hash all transactions:

in func (api *APIImpl) GetTransactionReceipt:

        block, err := api.blockByNumberWithSenders(ctx, tx, blockNum)
	if err != nil {
		return nil, err
	}
	if block == nil {
		return nil, nil // not error, see https://github.com/erigontech/erigon/issues/1645
	}

	var txnIndex uint64
	var txn types.Transaction
	for idx, transaction := range block.Transactions() {
		if transaction.Hash() == txnHash {
			txn = transaction
			txnIndex = uint64(idx)
			break
		}
	}
@AskAlexSharov AskAlexSharov added imp2 Medium importance erigon3 labels Dec 18, 2024
@JkLondon JkLondon linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erigon3 imp2 Medium importance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants