Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn inMem heuristic to bool cfg #11774

Open
AskAlexSharov opened this issue Aug 28, 2024 · 2 comments · Fixed by #12028 · May be fixed by #12104
Open

Turn inMem heuristic to bool cfg #11774

AskAlexSharov opened this issue Aug 28, 2024 · 2 comments · Fixed by #12028 · May be fixed by #12104
Assignees
@JkLondon
Labels
erigon3 imp2 Medium importance

Comments

@AskAlexSharov
Copy link
Collaborator

need get rid of inMemExec := txc.Doms != nil

Let's turn inMemExec and isMining into enum with 3 options:
Mining/ForkValidation/ApplyBlocks (feel free to propose better naming)

InMem - it's ForkValidation

Value let's store inside type Sync struct (we have 3 sync instances) and set to StageState.CurrentSyncCycle.Mode
@AskAlexSharov AskAlexSharov added erigon3 imp2 Medium importance labels Aug 28, 2024
@AskAlexSharov AskAlexSharov added this to the 3.0.0-beta1 milestone Aug 28, 2024
@mh0lt
Copy link
Contributor

mh0lt commented Aug 28, 2024

I think we should rename Mining to BlockProduction

@AskAlexSharov
Copy link
Collaborator Author

oke
BlocksProduction
ForkValidation
ApplyBlocks (or Sync or ?)

@JkLondon JkLondon mentioned this issue Sep 18, 2024
Merged
@yperbasis yperbasis modified the milestones: 3.0.0-beta1, 3.0.0-alpha4 Sep 19, 2024
@JkLondon JkLondon reopened this Sep 26, 2024
@JkLondon JkLondon linked a pull request Sep 26, 2024 that will close this issue
Open
@VBulikov VBulikov modified the milestones: 3.0.0-alpha4, 3.0.0-alpha5 Sep 27, 2024
@AskAlexSharov AskAlexSharov removed this from the 3.0.0-beta1 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JkLondon JkLondon

Labels
erigon3 imp2 Medium importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

InMem/Sync/IsMining replacement erigontech/erigon
[wip] Sync enum erigontech/erigon
5 participants
@VBulikov @yperbasis @AskAlexSharov @JkLondon @mh0lt