Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Require ergebnis/json-normalizer:^4.0.0 #956

Closed
wants to merge 2 commits into from

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Aug 10, 2022

This pull request

  • requires ergebnis/json-normalizer:dev-main as 4.0.0
  • adjusts class names

Related to #868.

@cafferata
Copy link

Hi @localheinz, I came to this issue because of the desire to use #868. I ran into the Composer constraint ergebnis/json-normalizer. So I've looked to see if someone already started an PR, and that's this PR. Can you tell me what you are still running into? Maybe some upgrade steps of the ergebnis/json-normalizer 3.0.0 release haven't been implemented yet? Is there anything I might be able to help with? 🙏

@localheinz
Copy link
Member Author

@cafferata

Apologies for the delay, picking up the work here soon!

@cafferata
Copy link

No apologies necessary. ☺️

@localheinz localheinz force-pushed the feature/json-normalizer branch from d08ef52 to 5e5c65a Compare January 3, 2023 17:24
@localheinz localheinz changed the title Enhancement: Require ergebnis/json-normalizer:^3.0.0 Enhancement: Require ergebnis/json-normalizer:^4.0.0 Jan 3, 2023
@localheinz localheinz force-pushed the feature/json-normalizer branch 3 times, most recently from 7dee96d to 0ab40f6 Compare January 5, 2023 19:45
@localheinz localheinz force-pushed the feature/json-normalizer branch from 0ab40f6 to 2440c32 Compare January 5, 2023 19:47
@localheinz
Copy link
Member Author

Closing in favour of #1056.

@localheinz localheinz closed this Feb 26, 2023
@localheinz localheinz deleted the feature/json-normalizer branch February 26, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants