Enhancement: Adjust ConfigHashNormalizer to also sort extra section #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/extra
branch
from
a38cd56 to
89fb7ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 100% 100%
- Complexity 67 68 +1
=======================================
Files 7 7
Lines 259 263 +4
=======================================
+ Hits 259 263 +4
Continue to review full report at Codecov.
|
|
Thank you, @ntzm and @hannesvdvreken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ConfigHashNormalizerto also sort theextrasection💁♂️ Not sure if this is a good idea, as it depends on how people use the
extrasection. Maybe order has a meaning there?