Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Deprecate the file argument #145

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Fix: Deprecate the file argument #145

merged 1 commit into from
Dec 24, 2018

Conversation

localheinz
Copy link
Member

This PR

  • deprecates the file argument

Fixes #144.

@localheinz localheinz added the bug label Dec 24, 2018
@localheinz localheinz self-assigned this Dec 24, 2018
@localheinz localheinz added this to the 1.1.0 milestone Dec 24, 2018
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #145 into 1.x will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #145      +/-   ##
============================================
+ Coverage     82.87%   82.96%   +0.09%     
  Complexity       36       36              
============================================
  Files             2        2              
  Lines           181      182       +1     
============================================
+ Hits            150      151       +1     
  Misses           31       31
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.28% <100%> (+0.07%) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb907fb...5ae774d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #145 into 1.x will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #145      +/-   ##
============================================
+ Coverage     82.87%   82.96%   +0.09%     
  Complexity       36       36              
============================================
  Files             2        2              
  Lines           181      182       +1     
============================================
+ Hits            150      151       +1     
  Misses           31       31
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.28% <100%> (+0.07%) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb907fb...5ae774d. Read the comment docs.

@localheinz localheinz merged commit 65c9a9a into 1.x Dec 24, 2018
@localheinz localheinz deleted the fix/deprecate branch December 24, 2018 16:03
@localheinz localheinz mentioned this pull request Dec 24, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz