Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider un-deprecating the file argument #165

Closed
marcmascort opened this issue Feb 1, 2019 · 5 comments
Closed

Consider un-deprecating the file argument #165

marcmascort opened this issue Feb 1, 2019 · 5 comments
Assignees
Labels

Comments

@marcmascort
Copy link

After reading issues #143 and #144 we believe is an error remove file argument.

We have a library to include in our developing projects that require all used packages to develop (lint, stan, ...), and composer normalize is one of these libraries.
With these method, we don't install composer normalize plugin globally, and only install on the project. Our development project has submodules, and we normalize submodules composer.json files from project composer using the argument file.
Without the argument file, and using --working-dir attribute of composer is impossible for us, use the composer normalize on submodules.
Removing the file attribute, force all developers to install normalize globally.

Please, could you reconsider deprecate file argument?

Thanks!

@localheinz
Copy link
Member

@marcmascort

Thank you for bringing this to my attention! I'll think about it and let you know. 🤓

@localheinz localheinz self-assigned this Feb 1, 2019
@localheinz localheinz changed the title [QUESTION] File argument Consider un-deprecating the file argument Feb 1, 2019
@localheinz
Copy link
Member

@marcmascort

And thanks again, I'm glad you find this project useful! I don't want to make it difficult for anyone using it to keep using it.

👍

@marcmascort
Copy link
Author

@localheinz If you can view our usage of yours tool: https://github.com/articstudio/php-bin

Thanks for this cool tool!

@localheinz
Copy link
Member

@marcmascort

Tagged as localheinz/composer-normalize:1.1.2!

I'm also reverting the removal of the file argument in master with #168.

@marcmascort
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants